Problem/Motivation

Add definition of this variable:-

/**
* {@inheritdoc}
*/

Steps to reproduce

Path : modules/fieldmask/src/Plugin/Field/FieldWidget/FieldMaskWidget.php

CommentFileSizeAuthor
#2 3329790-2.patch1.44 KBAnkitKumar1

Issue fork fieldmask-3329790

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AnkitKumar1 created an issue. See original summary.

AnkitKumar1’s picture

AnkitKumar1 commented
Assigned: AnkitKumar1 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3329790-2.patch1.44 KB

Please review this patch .

Sonal Gyanani made their first commit to this issue’s fork.

Sonal Gyanani opened merge request !4

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs review » Reviewed & tested by the community

Thanks @AnkitKumar1 patch working fine.
Moving it to RTBC

heni_deepak’s picture

heni_deepak commented
Status: Reviewed & tested by the community » Needs work

@Sonal Gyanani MR failed. please update.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will work on that

elber opened merge request !5

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I created a new MR because the old MR was broken. I pushed the same changes did in the comment #4 to new MR. please revise.

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs review » Reviewed & tested by the community

Thanks @elber, moving it to RTBC

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Reviewed & tested by the community » Needs work

Making NW

As per the discussion here.

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Manoj Raj.R’s picture

Manoj Raj.R commented
Assigned: Unassigned » Manoj Raj.R
Manoj Raj.R’s picture

Manoj Raj.R commented

Committed as per the Standard from DRUPAL ORG.

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Please review.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Manoj Raj.R » Unassigned
Status: Needs review » Needs work

Hi @Manoj Raj.R I revised your commit and almost all is good for me.

You just should to update the three line because limit number of characters has been exceeded.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review

Hi @elber,

I just revised the committed please review.

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs review » Reviewed & tested by the community

heni_deepak closed merge request !4

heni_deepak’s picture

heni_deepak commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.