Problem/Motivation

Missing README.md file

Steps to reproduce

Create 'README.md' file.

Follow the pattern in the README.md template.

CommentFileSizeAuthor
#7 3329113-7.patch724 bytesshubham rathore
#5 3329113-5.patch845 bytesshubham rathore
#2 3329113-2.patch79 bytescharchil khandelwal

Issue fork facebook_block-3329113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Charchil Khandelwal created an issue. See original summary.

charchil khandelwal’s picture

charchil khandelwal commented
Assigned: charchil khandelwal » Unassigned
Status: Active » Needs review
StatusFileSize
new 3329113-2.patch79 bytes
shubham rathore’s picture

shubham rathore commented
Assigned: Unassigned » shubham rathore
shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned

Hi Patch#2 apply and add README.md file in module folder but there no any information in README.md file.
Thank You

shubham rathore’s picture

shubham rathore commented
StatusFileSize
new 3329113-5.patch845 bytes

Please review this patch.

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
Status: Needs review » Needs work

Thanks, please follow the pattern under "README format" in the README.md template.

Maybe you can create an issue fork (click "Create issue fork") and commit to that, for easier preview?

shubham rathore’s picture

shubham rathore commented
StatusFileSize
new 3329113-7.patch724 bytes

Updated patch

shubham rathore’s picture

shubham rathore commented
Status: Needs work » Needs review
jay jangid’s picture

jay jangid commented
Assigned: Unassigned » jay jangid
jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned

Thanks @Shubham Rathore for patch.Now looks better.
Patch #7 work successfully.

ressa opened merge request !1

ressa’s picture

ressa
he/him
commented

I agree, it's almost there

Please, for easier preview and comments, use the Gitlab integration. I have created an issue fork and committed the patch from #7, with a few minor updates. Please review.

Sonal Gyanani made their first commit to this issue’s fork.

Sonal Gyanani’s picture

Sonal Gyanani commented

Fix some issues please review

Manoj Raj.R made their first commit to this issue’s fork.

Manoj Raj.R’s picture

Manoj Raj.R commented

Adding some formats from the project page with readme format.

heni_deepak made their first commit to this issue’s fork.

heni_deepak’s picture

heni_deepak commented
Status: Needs review » Fixed

thanks @all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.