This module is still using a blank README.txt file. Now Drupal.org migrated to Gitlab, it should be replaced with a README.md

Follow the pattern in the README.md template.

CommentFileSizeAuthor
#10 3329095-10.patch1.33 KBSonal Gyanani
#6 3329095-6.patch1.32 KBshubham rathore
#2 3329095-2.patch1.48 KBRashmi Gaurana

Issue fork files_upload-3329095

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rashmi Gaurana created an issue. See original summary.

Rashmi Gaurana’s picture

Rashmi Gaurana commented
StatusFileSize
new 3329095-2.patch1.48 KB

Created README.md file. Please review

Rashmi Gaurana’s picture

Rashmi Gaurana commented
Assigned: Rashmi Gaurana » Unassigned
Status: Active » Needs review
ressa’s picture

ressa
he/him
commented
Issue summary: View changes
Status: Needs review » Needs work

Thanks @Rashmi Gaurana, that's a great start.

Please follow the pattern under "README format" in the README.md template. Headers should not be ALL CAPITALS, module name is missing, and there are leading spaces.

Maybe you can create an issue fork (click "Create issue fork") and commit to that, for easier preview?

shubham rathore’s picture

shubham rathore commented
Assigned: Unassigned » shubham rathore
shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
StatusFileSize
new 3329095-6.patch1.32 KB

Hi please review this patch.

shubham rathore’s picture

shubham rathore commented
Status: Needs work » Needs review
Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Unassigned » Sonal Gyanani
Sonal Gyanani’s picture

Sonal Gyanani commented

Patch #6 works fine but have some "README format" issues.
There are leading spaces.
Links should have meaningful link text like introduction section looks like this

- For a full description of the module, visit the project page:
  [project page](https://www.drupal.org/project/files_upload).

- To submit bug reports and feature suggestions, or to track changes:
  [issue queue](https://www.drupal.org/project/issues/files_upload).

There should be two lines prior to headings.
So working on this to create updated patch

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Sonal Gyanani » Unassigned
StatusFileSize
new 3329095-10.patch1.33 KB

Update patch #6 according to format please review.
Thanks

ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Thanks @Sonal Gyanani, that looks better.

Maybe you can create an issue fork (click "Create issue fork") and commit to that, for easier preview?

Sonal Gyanani opened merge request !5

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs work » Needs review

Thanks @ressa, I created issue fork.
Please review

ressa’s picture

ressa
he/him
commented

Thanks @Sonal Gyanani, that looks great! I have made a few minor adjustments, please review.

heni_deepak made their first commit to this issue’s fork.

heni_deepak’s picture

heni_deepak commented
Status: Needs review » Fixed
ressa’s picture

ressa
he/him
commented

Perfect @heni_deepak, the README.md looks great.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.