Problem/Motivation

In certain situations, a rule can get deleted before the entity that references it is deleted. This results in an error when smart_date_recur_entity_delete() tries to delete the rule and finds it already gone.

Steps to reproduce

I don't know about a vanilla install, but on our site, this occurs when a node is deleted by its owner rather than by an administrator.

Proposed resolution

Check that the rrule object exists before trying to delete it.

Remaining tasks

Make a patch.

CommentFileSizeAuthor
#2 smart_date_recur-3328855-2.patch566 bytesbenstallings

Comments

BenStallings created an issue. See original summary.

benstallings’s picture

Status: Active » Needs review
StatusFileSize
new566 bytes

  • mandclu committed fe67d31e on 3.7.x
    Issue #3328855 by BenStallings: call to a member function delete() on...
mandclu’s picture

Version: 3.6.x-dev » 3.7.x-dev
Status: Needs review » Fixed

Thanks for identifying this, and for providing a fix. Merged into the 3.7.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.