Problem/Motivation

As requested by @catch in #3327769-4: Upgrade Symfony dependencies to 6.2.2 now in a separate issue: Update doctrine/annotations-dependency.

Steps to reproduce

Proposed resolution

~/.config/composer/vendor/bin/composer-lock-diff --no-links
+----------------------+--------+--------+
| Production Changes   | From   | To     |
+----------------------+--------+--------+
| doctrine/annotations | 1.13.3 | 1.14.2 |
+----------------------+--------+--------+

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Spokje created an issue. See original summary.

spokje’s picture

StatusFileSize
new3.17 KB
spokje’s picture

Status: Active » Needs review
andypost’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +10.1.0 release notes

Looking at release notes https://github.com/doctrine/annotations/releases

Minor release 1.14.0 added forward compatibility with lexer v2 https://github.com/doctrine/annotations/pull/460

spokje’s picture

Issue summary: View changes
xjm’s picture

Status: Reviewed & tested by the community » Needs work

Let's also update the constraint for this. (For the past several minors, we've adopted a best practice of setting the minor version constraints to the highest working version with each new core minor.) Thanks!

spokje’s picture

Status: Needs work » Needs review
StatusFileSize
new3.63 KB
new3.63 KB
new408 bytes

Fine by me :)

xjm’s picture

Status: Needs review » Needs work

The last submitted patch, 7: 3327787-10.1.x-7.patch, failed testing. View results

xjm’s picture

Ah, I bet the hashes need to be regenerated due to the Symfony patch release commit. This will also be true with the Doctrine issue for whichever of these two lands first.

spokje’s picture

Issue summary: View changes
StatusFileSize
new3.15 KB
new4.84 KB

New version out, let's make this a 10.1.x patch first to see what happens.

spokje’s picture

Status: Needs work » Needs review

Unsure where the "sudden" need for a hash change came from, but it's (again) unneeded now.

andypost’s picture

Status: Needs review » Reviewed & tested by the community
+++ b/composer.lock
@@ -290,32 +290,35 @@
+            "suggest": {
+                "php": "PHP 8.0 or higher comes with attributes, a native replacement for annotations"

nice to see that)

catch’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a re-roll. #13 confirms why #3252386: Use PHP attributes instead of doctrine annotations needs to be critical - we need to phase out annotations before Doctrine completely drops it.

spokje’s picture

Issue tags: -Needs reroll
StatusFileSize
new4.84 KB

Rerolled

spokje’s picture

Status: Needs work » Needs review
catch’s picture

Status: Needs review » Fixed

Committed bcbd7ba and pushed to 10.1.x. Thanks!

  • catch committed bcbd7baa on 10.1.x
    Issue #3327787 by Spokje, xjm, andypost: Update doctrine/annotations to...
catch’s picture

catch’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

This change is covered by the standard minor release note of:

Drupal core's pinned Composer dependency versions have been updated for the latest minor and patch releases.
Additionally, Drupal core’s composer constraints have been increased to require the latest minor version for forward compatibility. This ensures that if any composer package that Drupal core depends upon has a security release, the Drupal core security update will be non-disruptive, because if possible no minor version increase will occur for the affected dependency, only a patch version increase.