Problem/Motivation

  • Add following functions for Openstack Port in SPA:
    • Detailed view
    • List view
    • Create
    • Delete
    • Edit

Issue fork cloud-3326759

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !1480

masami’s picture

masami commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@masami

Thank you for adding the OpenStack port entity. Can you please check the following coding standard violations?

FILE: ...ce_providers/openstack/src/Controller/ApiControllerInterface.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 394 | ERROR | [x] Whitespace found at end of line
 406 | ERROR | [x] Expected 1 blank line after function; 2 found
 407 | ERROR | [x] Whitespace found at end of line
 409 | ERROR | [x] The closing brace for the interface must have an
     |       |     empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 53.31 secs; Memory: 72.01MB

Thanks!

masami’s picture

masami commented
Status: Needs work » Needs review
ryo yamashita’s picture

ryo yamashita commented

@masami

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@masami

It looks good, so I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • 8be3508 committed on 5.x 
    Issue #3326759 by Masami, yas, Ryo Yamashita: Add the functions for...

  • yas committed 57af130 on 4.x 
    Issue #3326759 by Masami, yas, Ryo Yamashita: Add the functions for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.