Problem/Motivation

The $schema property is wrongly typed.

Proposed resolution

Fix it.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3325772-3.patch788 bytesandypost
#3 interdiff.txt806 bytesandypost
#2 3325772-2.patch564 bytesmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 3325772-2.patch564 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt806 bytes
new 3325772-3.patch788 bytes

I think better to type this properties via native types as we touch the trait

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me but that makes it non portable to 9.5.

  • catch committed 539f85f on 10.0.x 
    Issue #3325772 by andypost, mondrake: Fix wrong property typehinting in...
  • catch committed a56cbf5 on 10.1.x
    Issue #3325772 by andypost, mondrake: Fix wrong property typehinting in...
  • catch committed a54f89a on 9.5.x
    Issue #3325772 by andypost, mondrake: Fix wrong property typehinting in...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

I went ahead and committed #3 to 10.1.x, and #2 to 10.0.x and 9.5.x. The extra type hinting on a property shouldn't make any different but I wondered what happens if something using the trait sets it to something invalid.

mondrake’s picture

mondrake
Location 🇮🇹
commented

I wondered what happens if something using the trait sets it to something invalid

TypeError for sure. So +1 better leave (native) type tightening to 10.1.x that is a bit ahead.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.