Problem/Motivation

When running composer install, several of the patches to contrib modules no longer apply.

Steps to reproduce

Create a new Panopoly site from the Composer template using the recommended command:
composer create-project panopoly/panopoly-composer-template:9.x-dev somedir --no-interaction

Output for Page Manager patch:

- Applying patches for drupal/page_manager
    https://www.drupal.org/files/issues/2021-08-17/page_manager-lb-title-3176661-3.patch (Issue #3176661: Allow to edit page title when using Layout Builder variant)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2021-08-17/page_manager-lb-title-3176661-3.patch

Output for Entity Embed patches:

  - Applying patches for drupal/entity_embed
    https://www.drupal.org/files/issues/2019-10-18/entity-embed-array-to-string--3069448-19.patch (Issue #3069448: Array to string conversion for Media Image)
    https://git.drupalcode.org/project/entity_embed/-/commit/3184cd06637e02b397c20b50c53c19835a843d21.diff (Issue #3260833: Construction of EntityEmbedDisplay plugin instances trigger strpos deprecation on PHP 8.1)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/entity_embed/-/commit/3184cd06637e02b397c20b50c53c19835a843d21.diff

Proposed resolution

Update the patches in Panopoly's composer.json. Entity Embed has a new release that fixes the patched issue; Page Manager has an updated/rerolled patch.

Remaining tasks

Patch and test.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork panopoly-3325645

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

cboyden created an issue. See original summary.

cboyden’s picture

Status: Active » Needs review

  • dsnopek committed 9acdb7b on 8.x-2.x authored by cboyden
    Issue #3325645 by cboyden: Update patches for contrib modules
    
dsnopek’s picture

Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.