Problem/Motivation

There's a lot of code in the LikeForm.php that gets/sets a cookie for anon. users, we should have all that part on a tested service.

Issue fork like-3325602

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pcambra created an issue. See original summary.

hardikpandya’s picture

hardikpandya commented
Version: » 1.x-dev
Assigned: Unassigned » hardikpandya

hardikpandya opened merge request !2

hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Active » Needs review
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Needs work

This is a good first step, now it needs to be moved to a service :)

hardikpandya’s picture

hardikpandya commented

It is already added under like.helper service. Do you mean a separate service only for cookie operations?

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Yes, a dedicated, and tested service that takes care of the cookies through the module.

hardikpandya’s picture

hardikpandya commented
Issue tags: +Needs tests, +Novice

I have added cookie operations in a separate service file. Keeping this `Needs Work` for anyone to add tests.