Fix PHPStan L2 error in traits

@mallezie The last patch doesn't pass commit checks, could you make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel...

Fixed the issue.

Testbot is not a happy bunny...

Pulled changes for 10.1 this morning but looks like there were more short while ago.

That one I can't explain. Locally it passes.

Adding parent

Recreated the PHPStan baseline, let's see what TestBot thinks

Looks like the changes in the patch break some/quite a lot of tests...

+++ b/core/modules/rest/tests/src/Functional/BasicAuthResourceTestTrait.php
@@ -23,7 +23,7 @@ trait BasicAuthResourceTestTrait {
-        'Authorization' => 'Basic ' . base64_encode($this->account->name->value . ':' . $this->account->passRaw),
+        'Authorization' => 'Basic ' . base64_encode($this->account->getAccountName()->value . ':' . $this->account->passRaw),

I think this is the cause of all the broken tests. getAccountName returns a string, so value isn't needed.

+++ b/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php
@@ -191,7 +191,13 @@ protected function createScreenshot($filename, $set_background_color = TRUE) {
+   * @return \Drupal\Tests\WebAssert
+   *   A new web-assert option for asserting the presence of elements with.

I think we should be able to change the return here to WebDriverWebAssert and that should hopefully stop another 500 or so errors being thrown. Specifically the ones with Call to an undefined method Drupal\Tests\WebAssert::{method}

The patch also doesn't apply to 10.1.x anymore, fixed the issues but couldn't get the baseline to regenerate properly. I was getting a lot of new warnings added to the baseline

Self addressed the feedback in #14 and regenerated the baseline. Lets see how the tests go.

Believe I tested this one write

I applied the patch
Changed the level to 2
Staged everything
./core/scripts/dev/commit-code-check.sh --cached
Got no errors.

Let me know if I missed a step for these level 2 stuff.

Should this be postponed on #3352916: Fix PHPStan L1 errors "Call to method getDefinitions()/getSortedDefinitions() on an unknown class Drupal\Core\Plugin\CategorizingPluginManagerTrait.", or should that part of the change here be removed, given it interferes with the fix there?

Oh good call. Yeah I think we should remove it from this issue. Thats only one part of this patch, so we can just remove it and regenerate the baseline

Looks like the problem isn't fixed yet.

Is there a better solution to it other than adding an @phpstan-ignore-next-line?

Manually applied parts of #15 that weren't already resolved in HEAD and pushed up a new MR. Hiding patches.

Changes look good, the only thing I noticed missing from the original patch were the changes to BasicAuthResourceTestTrait::getAuthenticationRequestOptions. Should they be included in this?

Other that that it looks good and is ready to be RTBC, just checking in on that one first.

Good spotting, I'm not sure why that one didn't make it initially. I generated the baseline at level 2, then updated that method and regenerated it. This removed a further 96 errors from the baseline, so I think that's worth it.

Seems feedback has been addressed.

Thanks, having tried level 2 locally and run into the many duplicated errors caused by traits I think this is worthwhile to clean up now so we can try to get a reasonable baseline before going to level 2 for real.