Problem/Motivation

When overriding the configuration for one of the clients, config_override_warn does not detect that it is overridden.
That's because OpenIDConnectSettingsForm::getEditableConfigNames() does not return the client configurations.

Steps to reproduce

  1. Install openid_connect and config_override_warn.
  2. Add something like this to your settings.php file:
    $config['openid_connect.settings.generic']['settings']['authorization_endpoint'] = 'https://example.com/oauth2/authorize';
  3. Then browse to /admin/config/services/openid-connect
  4. No warning is displayed

Proposed resolution

OpenIDConnectSettingsForm::getEditableConfigNames() should return every configuration handled by this form.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

prudloff created an issue. See original summary.

prudloff’s picture

Status: Active » Needs review
sanduhrs’s picture

Version: 8.x-1.2 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

  • sanduhrs committed cbf326c6 on 8.x-1.x authored by prudloff
    Issue #3324523 by prudloff: Does not work with config_override_warn
    
sanduhrs’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.