Problem/Motivation

This module is not yet compatible with Drupal 10.

CommentFileSizeAuthor
#6 Drupal-10-compatibility-3324147-6.patch4.35 KBmaxmendez
#4 Drupal-10-compatibility-3324147-4.patch4.32 KBmaxmendez

Issue fork fontawesome_menu_icons-3324147

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff opened merge request !1

prudloff’s picture

prudloff commented
Status: Active » Needs review

The main change is the new once library: https://www.drupal.org/node/3158256
This means we have to drop Drupal 8 support.

maxmendez’s picture

maxmendez commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Drupal-10-compatibility-3324147-4.patch4.32 KB

Here a first approach to get Drupal 10 compatibility.

Done:

  • Migrate fromcore/jquery.once to core/once
  • Drop 8 compatibility and added with 10.
lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Reviewed & tested by the community » Needs work

Thank you! Please change the minimum core version to ^9.2, as the new once library was introduced in this version.

core_version_requirement: ^9.2 || ^10
maxmendez’s picture

maxmendez commented
StatusFileSize
new Drupal-10-compatibility-3324147-6.patch4.35 KB

Thanks.

lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Needs review

But I just noticed that @prudloff has already made a merge request with these changes.

maxmendez’s picture

maxmendez commented

😳 That's right. Sorry.

lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs review » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.