Problem/Motivation

Some works from https://www.drupal.org/project/ui_suite_bootstrap/issues/3319153 can be ported to 5.x

Changes done

Patterns:

  • ⚠ Compatibility breaker. list_group: remove non-compliant #active & #disabled properties by splitting list_group & list_group_item
    >> DONE 60806a744a9a1da948a0cb63bed131d997e37299
  • ⚠ Compatibility breaker. Carousel: remove _ui_suite_bootstrap_extract_carousel_image hook, split slides field between slides and captions, and don't forget to update the "carousel" example.
    >> This change is controversial & challenged. Let's discuss with other maintainers first.

Styles:

  • Add p-* & m-* styles, because already used for previews and expected by users.
    >> DONE. 4af872e3221317973d66f06ffe52f4921a8fe63b
  • Add text-end previewed_with for spacing_padding_end
    >> DONE. 4af872e3221317973d66f06ffe52f4921a8fe63b
  • Compatiblity breaker. Split border & border substractive
    >> DONE. 4af872e3221317973d66f06ffe52f4921a8fe63b
  • Compatibility breaker. Merge some styles when their options are mutually exclusive? Examples:
    • Background color VS Background color with contrasting color
      >> DONE. 1a9e644ffdf8f3505b55bc8752e759fcae962da6
    • Font size VS Typography
      >> DONE. 1a9e644ffdf8f3505b55bc8752e759fcae962da6
    • Merge ratio_ratio and ratio_aspect if possible to have a space in the option key
    • Some Flex stuff: Flex Grow VS Flex Shrink ? => Merged
    • Remove negatives from spacing_padding_* & spacing_margin_* as it is not in the default compiled Bootstrap CSS >> To discuss: as it only a recompilation of the CSS to enable that.

    Examples:

    • ⚠ Remove 0, 1, 2.. top level string because it is useless and fragile
      >> DONE. 28cd3306fb9981a05c146d96ca1c6952b1d24542
    • Remove "Bootstrap" from label
      >> DONE. 28cd3306fb9981a05c146d96ca1c6952b1d24542

    Postponed tasks

    Styles:

    • Remove styles: flex_* / display_* and position_* >> To discuss
    • Merge visibility && opacity && visually_hidden? >> Those classes do not impact the same CSS properties so maybe not

    API changes

    Yes, see "Compatibility breaker" lines.

Issue fork ui_suite_bootstrap-3323951

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue summary: View changes
pdureau’s picture

pdureau commented
Issue summary: View changes
pdureau’s picture

pdureau commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: pdureau » grimreaper

Work done on https://git.drupalcode.org/project/ui_suite_bootstrap/-/tree/5.0.x-pdureau.

I will create a proper issue fork and MR.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work

Grimreaper opened merge request !28

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Proper fork and MR created. I have rebased locally 5.0.x-pdureau.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: Bootstrap 5: port 4.0.0-alpha2 fixes & improvments » Bootstrap 5: port 4.0.0-alpha2 fixes & improvements
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

Updating issue summary to more easily see remaining points.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

Adding propositions from discussion with @pdureau.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Merge ratio_ratio and ratio_aspect if possible to have a space in the option key

It is possible >> Commiting the change.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

Merged flex_grow and flex_shrink.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue summary: View changes

  • Grimreaper committed 3cb27789 on 5.0.x 
    Issue #3323951 by Grimreaper: Rework carousel pattern.

  • Grimreaper committed e28b8532 on 5.0.x 
    Issue #3323951 by Grimreaper, pdureau: Remove negative margin and...

  • Grimreaper committed 292ee304 on 5.0.x 
    Issue #3323951 by Grimreaper: Merge styles flex_grow and flex_shrink.

  • Grimreaper committed 2267d7a7 on 5.0.x 
    Issue #3323951 by Grimreaper: Merge styles ratio_ratio and ratio_aspect.

  • Grimreaper committed a18a5c16 on 5.0.x authored by pdureau 
    Issue #3323951: Merge some styles when their options are mutually...

  • Grimreaper committed 9210f65b on 5.0.x authored by pdureau 
    Issue #3323951: Remove 0, 1, 2.. string from top level, and remove '...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Issue summary: View changes
Status: Needs work » Fixed

I have retested to see if opacity, visibility and visually hidden styles could be merged. It addresses different problematic, so I don't think it is to be merged.

Also not removed flex_* / display_* and position_* yet.

If needed, let's see those points in dedicated issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.