Problem/Motivation

  • Fix the programming errors

Issue fork cloud-3323864

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !1435

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@baldwinlouie @xiaohua-guan @ryo-yamashita @masami

Can you please review the patch? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for your review. I fixed the ones. Can you double-check the patch again? Thanks!

sekinet’s picture

sekinet commented

@yas

It looks good to me.

baldwinlouie’s picture

baldwinlouie commented

@yas, thanks for the patch. It looks good to me!

masami’s picture

masami commented

@yas
The patch looks good to me.

xiaohua guan’s picture

xiaohua guan commented

@yas

It looks good to me. Thanks.

ryo yamashita’s picture

ryo yamashita commented

@yas

It looks good to me, too. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet
@baldwinlouie
@masami
@ryo-yamashita
@xiaohua-guan

Thank you for your review. It looks good, so I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • 77f1e00 committed on 5.x 
    Issue #3323864 by yas, sekinet, baldwinlouie, Masami, Ryo Yamashita,...

yas opened merge request !1464

  • 4c82502 committed on 4.x 
    Issue #3323864 by yas, sekinet, baldwinlouie, Masami, Ryo Yamashita,...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.