Problem/Motivation

https://github.com/symfony/symfony/releases/tag/v6.2.0-RC1

Steps to reproduce

COMPOSER_ROOT_VERSION=10.1.x-dev composer update symfony/* -W

Proposed resolution

$ ~/.composer/vendor/bin/composer-lock-diff --no-links
+------------------------------+--------------+------------+
| Production Changes           | From         | To         |
+------------------------------+--------------+------------+
| symfony/console              | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/dependency-injection | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/error-handler        | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/event-dispatcher     | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/http-foundation      | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/http-kernel          | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/mime                 | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/process              | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/routing              | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/serializer           | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/validator            | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/var-dumper           | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/var-exporter         | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/yaml                 | v6.2.0-BETA3 | v6.2.0-RC1 |
+------------------------------+--------------+------------+

+------------------------+--------------+------------+
| Dev Changes            | From         | To         |
+------------------------+--------------+------------+
| symfony/browser-kit    | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/css-selector   | v6.2.0-BETA1 | v6.2.0-RC1 |
| symfony/dom-crawler    | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/filesystem     | v6.2.0-BETA1 | v6.2.0-RC1 |
| symfony/finder         | v6.2.0-BETA1 | v6.2.0-RC1 |
| symfony/lock           | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/phpunit-bridge | v6.2.0-BETA3 | v6.2.0-RC1 |
+------------------------+--------------+------------+

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#20 3323741-10.1-20.patch37.49 KBandypost
#20 3323741-10.0-20.patch37.49 KBandypost
#20 interdiff.txt2.14 KBandypost
#19 3323741-10.1-19.patch36.13 KBandypost
#19 3323741-10.0-19.patch36.13 KBandypost
#19 interdiff.txt818 bytesandypost
#17 3323741-10.1-17.patch35.33 KBandypost
#17 interdiff.txt1.3 KBandypost
#16 3323741-d10.0.x-15.patch35.33 KBspokje
#13 interdiff.txt460 bytesandypost
#12 3323741-12-10.0.patch35.17 KBandypost
#8 3323741-7.patch35.17 KBspokje
#7 interdiff.2-7.txt9.49 KBspokje
#7 interdiff.2-7.txt9.49 KBspokje
#5 3323741-5.patch35.4 KBspokje
#5 interdiff.2-5.txt9.66 KBspokje
#2 3323741-2.patch24.69 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3323741-2.patch24.69 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3323741-2.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3323741-interdiff.txt1.13 KB
new 3323741-4.patch25.82 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new interdiff.2-5.txt9.66 KB
new 3323741-5.patch35.4 KB

The last submitted patch, , failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new interdiff.2-7.txt9.49 KB
new interdiff.2-7.txt9.49 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3323741-7.patch35.17 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/phpstan.neon.dist
@@ -5,7 +5,7 @@ includes:
-  level: 1
+  level: 2

that's unrelated change

spokje’s picture

spokje
Primary language Dutch
commented

that's unrelated change

Yes sorry, didn't clear my workspace switching issues.
Removed it in patch #8.

catch’s picture

catch
he/him
Primary language English
commented 
+++ b/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
@@ -32,7 +32,7 @@ class ComposerProjectTemplatesTest extends ComposerBuildTestBase {
    */
-  protected const MINIMUM_STABILITY = 'beta';
+  protected const MINIMUM_STABILITY = 'RC';

This is what I missed in #4...

Looks like we need a 10.0.x-specific version but otherwise all looks good.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3323741-12-10.0.patch35.17 KB

here's as 10.0 has no mck89/peast

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt460 bytes

the only change is hash

Status: Needs review » Needs work

The last submitted patch, 12: 3323741-12-10.0.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented 
+++ b/composer.lock
@@ -471,18 +471,18 @@
                 "symfony/console": "^6.2@beta",

symfony/console is still beta.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3323741-d10.0.x-15.patch35.33 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.3 KB
new 3323741-10.1-17.patch35.33 KB

patch #8 missing console upgrade as well

The last submitted patch, 16: 3323741-d10.0.x-15.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt818 bytes
new 3323741-10.0-19.patch36.13 KB
new 3323741-10.1-19.patch36.13 KB

Last missing hunk

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3319794: Update to Symfony 6.2 RC or update drupal/recommended-project creation and testMinimumStabilityStrictness() to allow minimum-stability to be less stable than core's stability
StatusFileSize
new interdiff.txt2.14 KB
new 3323741-10.0-20.patch37.49 KB
new 3323741-10.1-20.patch37.49 KB

and another one from #3319794: Update to Symfony 6.2 RC or update drupal/recommended-project creation and testMinimumStabilityStrictness() to allow minimum-stability to be less stable than core's stability

The last submitted patch, 19: 3323741-10.0-19.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 20: 3323741-10.1-20.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

The Symfony updates all look correct to me and the temporary project stability changes from #3319794: Update to Symfony 6.2 RC or update drupal/recommended-project creation and testMinimumStabilityStrictness() to allow minimum-stability to be less stable than core's stability have been reverted, the tests pass so this is RTBC.

  • catch committed 24a3203 on 10.0.x 
    Issue #3323741 by andypost, Spokje, catch, longwave: upgrade Symfony...
  • catch committed 7fa1fe8 on 10.1.x
    Issue #3323741 by andypost, Spokje, catch, longwave: upgrade Symfony...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.