Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3323343-7-after.png8.06 KBshyam_bhatt
#7 3323343-7-before.png7.73 KBshyam_bhatt
#6 3321478-6.patch428 bytessakthivel m
#4 After.png12.12 KBsharayurajput
#4 Before.png12.12 KBsharayurajput
#2 3323343-2.patch291 bytessakthivel m
Screenshot 2022-11-23 at 4.06.12 PM.png37.84 KBsakthivel m

Comments

Sakthivel M created an issue. See original summary.

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3323343-2.patch291 bytes

#2 Please review the Patch

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

I will review this patch

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before.png12.12 KB
new After.png12.12 KB

Patch is applied properly its working as per requirement LGTM so moving to RTBC

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Needs work

Not Dark Theme compatible. Remember to always focus to have Dark/Gray Background whenever is possible.

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Needs review
StatusFileSize
new 3321478-6.patch428 bytes

@Diego_Mow thank you for the suggestions.

#6 Please review the patch

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3323343-7-before.png7.73 KB
new 3323343-7-after.png8.06 KB

Reviewed the patch "3321478-6.patch" from comment #6. Working fine.

Before:
2022-12-06/3323343-7-before.pnge:

After:
2022-12-06/3323343-7-after.png

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Fixed
diego_mow’s picture

diego_mow commented
Status: Fixed » Closed (fixed)