Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3323301-7-after.png24.94 KBshyam_bhatt
#6 3323301-6.patch305 bytessakthivel m
#6 After-patch.png251.2 KBsakthivel m
#6 Before-patch.png111.25 KBsakthivel m
#4 After.png41.57 KBsharayurajput
#4 Before.png64.06 KBsharayurajput
#2 3323301-2.patch387 bytessakthivel m
Screenshot 2022-11-23 at 12.10.46 PM.png216.76 KBsakthivel m

Comments

Sakthivel M created an issue. See original summary.

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3323301-2.patch387 bytes
sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

I will review this patch

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before.png64.06 KB
new After.png41.57 KB

Patch is applied properly and its working as per requirement and LGTM so moving to RTBC

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Needs work

Header with hover is acting 100% different between stick and non-stick.
Please make both look the same way.

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Needs review
StatusFileSize
new Before-patch.png111.25 KB
new After-patch.png251.2 KB
new 3323301-6.patch305 bytes

@Diego_Mow Thank you for the suggestions

#6 Please review the patch

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3323301-7-after.png24.94 KB

Reviewed the patch "3323301-6.patch" from comment #6. Working fine.

After:
2022-12-06/3323301-7-after.png

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Fixed

  • Sakthivel M authored 6c491b84 on 1.0.x 
    Issue #3323301 by Sakthivel M, sharayurajput, Shyam_Bhatt, Diego_Mow: On...
diego_mow’s picture

diego_mow commented
Status: Fixed » Closed (fixed)