Warning: Trying to access array offset on value of type null in Drupal\node_revision_delete\NodeRevisionDelete->updateTimeMaxNumberConfig()
Both a further fix is needed and a correction after #3279731: Handle NULL third_party_settings in updateTimeMaxNumberConfig().
It looks to me that the intent of #3279731: Handle NULL third_party_settings in updateTimeMaxNumberConfig() was to just fix a warning but not change the behavior.
It did fix the warning for the case when third party settings is completely undefined but it did not fix the same warning for the case when the third party settings for node_revision_delete were undefined.
At the same time that fix changed the behavior to now save (partial) config when the setting was undefined. The old behavior was to effectively only save when an old value existed (and was bigger), only doing so when a positive integer was smaller than an existing value or smaller than an undefined value evaluating to 0.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | node_revision_delete-updateTimeMaxNumberConfig-3323170-4.patch | 903 bytes | eric_a |
Comments
Comment #2
eric_a commentedComment #3
eric_a commentedComment #4
eric_a commentedIt looks to me that the intent of #3279731: Handle NULL third_party_settings in updateTimeMaxNumberConfig() was to just fix a warning but not change the behavior.
It did fix the warning for the case when third party settings is completely undefined but it did not fix the same warning for the case when the third party settings for node_revision_delete were undefined.
At the same time that fix changed the behavior to now save (partial) config when the setting was undefined. The old behavior was to effectively only save when an old value existed (and was bigger), only doing so when a positive integer was smaller than an existing value or smaller than an undefined value evaluating to 0.
So here's a patch that fixes warnings and changes the behavior back to pre RC5.
Comment #5
eric_a commentedComment #6
eric_a commentedPerhaps an unintended behavior change in RC5 warrants priority major.
Comment #7
eric_a commentedComment #8
eric_a commentedComment #10
adriancidThanks
Comment #11
eric_a commentedComment #12
eric_a commentedOops, when changing the title (again) I hadn't noticed that the issue was already fixed.
@adriancid, thanks for the quick action!
(Not sure what to do with the title now.)
Comment #13
adriancidYou can leave it as it is, google will do the rest :-D