Problem/Motivation

Currenty contrib cannot be tested with php 8.2 due to lack of support in phpspec/prophecy, and it is not possible to ignore PHP version requirements as options in gather_dependencies step are not overridable

Steps to reproduce

Try to run contrib testing with PHP8.2, see #3318421: Add a php8.2_mysql8_ignore environment so that contrib can run tests on PHP 8.2 despite phpspec/prophecy

Proposed resolution

Pass composer options from PIFT to the gather_dependencies step (this is already supported for core install)

Remaining tasks

Review patch

User interface changes

None

API changes

None

Data model changes

None

Issue fork drupalci_testbot-3323103

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • dev Comparechanges, plain diff MR !6
About issue forks

Comments

Taran2L created an issue. See original summary.

Taran2L opened merge request !6

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review

Small note: I've enabled ignoring PHP requirements for phpstan installation step, as it is strictly a dev tool and I don't see any harm by doing so. Let me know your thoughts.

hestenet made their first commit to this issue’s fork.

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

Changes look good to me, and it seems reasonable to make this change for PHPstan as well.

Thanks very much for the contributions @Taran2L, will look to get deployed and tested shortly.

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

It is working properly, see #3318421: Add a php8.2_mysql8_ignore environment so that contrib can run tests on PHP 8.2 despite phpspec/prophecy

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.