Problem/Motivation

The following functions have wrong parameter type set in PHPDoc

locale_translation_check_projects() $langcodes is array, not string

locale_translation_check_projects_batch() $langcodes is array, not string

Steps to reproduce

Proposed resolution

I think we should use PHPStan or PHPDoctor to find all bad PHPDoc param types in Drupal core, and fix them.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3323057-2.patch982 bytesArti Anil Pattewar

Comments

Pasqualle created an issue. See original summary.

Arti Anil Pattewar’s picture

Arti Anil Pattewar commented
StatusFileSize
new 3323057-2.patch982 bytes

submitting patch for comment change. Please review.

Arti Anil Pattewar’s picture

Arti Anil Pattewar commented
Status: Active » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 9.5.x-dev » 10.1.x-dev
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Seems straightforward enough :)

  • catch committed b8a64b7 on 10.1.x 
    Issue #3323057 by Arti Anil Pattewar, Pasqualle: Invalid PHPDoc comments

  • catch committed 15673f3 on 10.0.x 
    Issue #3323057 by Arti Anil Pattewar, Pasqualle: Invalid PHPDoc comments...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.