Problem/Motivation

1. Missing paddings on the highlighted node container.
2. The article image sticks out of the highlighted area.

See attached screenshot.

Proposed resolution

I think we need to find a different way to indicate that a viewed node is unpublished.

CommentFileSizeAuthor
#6 after.png1.73 MBenaznin
#5 Screenshot 2023-02-27 at 4.53.49 PM.png1.76 MBenaznin
olivero-unpublished-node.png3.39 MBchi

Issue fork drupal-3323028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chi created an issue. See original summary.

enaznin’s picture

enaznin commented
Assigned: Unassigned » enaznin

enaznin opened merge request !3557

enaznin’s picture

enaznin commented
Version: 10.0.x-dev » 10.1.x-dev
enaznin’s picture

enaznin commented
StatusFileSize
new Screenshot 2023-02-27 at 4.53.49 PM.png1.76 MB

Added padding and max-width to the image inside the node so it doesn't break. Attached before after screenshot.

enaznin’s picture

enaznin commented
StatusFileSize
new after.png1.73 MB

_pratik_ made their first commit to this issue’s fork.

enaznin’s picture

enaznin commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs subsystem maintainer review

I think we need to find a different way to indicate that a viewed node is unpublished.

What was agreed upon to do that?

Will need approval from olivero maintainer also.

enaznin’s picture

enaznin commented
Assigned: enaznin » Unassigned
andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Title: Olivero: Unpublished nodes look weird » Olivero: Update styles for unpublished nodes
Priority: Normal » Minor

1. Missing paddings on the highlighted node container.
2. The article image sticks out of the highlighted area.

The padding of unpublished nodes matches the padding of published nodes, and the article images are supposed to overflow the boundaries, per the design. We don't really want published/unpublished nodes to be dramatically visually different. I'm not opposed to finding a better "less weird" set of styles, but unless there's a real usability issue that warrants it, I don't think this ticket is really worth pursuing.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.