Problem/Motivation

  • Add a documentation to help fix Cloud Dashboard.

Issue fork cloud-3322833

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1426

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add documentation to help fix Cloud Dashboard » Add the information to help Cloud Dashboard development
Issue summary: View changes

@ryo-yamashita

Thank you for adding the document. I think the information should be included into README.md.

@baldwinlouie

What do you think?

Thanks

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@yas and @ryo-yamashita, I added my comments. I also think we can just put all of this in README.md

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas @baldwinlouie

I have fixed the document in accordance with your comments.
Please review it again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@baldwinlouie

Thank you for your review. I agree to your comments.

@ryo-yamashita

Thank you for the update. I posted my minor commnet. Can you please check it? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. As Baldwin agreed, too, can you move the information to README.md? Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add the information to help Cloud Dashboard development » Add the information to README.md to help Cloud Dashboard development
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 9f5e4db on 5.x authored by Ryo Yamashita 
    Issue #3322833 by Ryo Yamashita, yas, baldwinlouie: Add the information...

  • yas committed ecc26cc on 4.x 
    Issue #3322833 by Ryo Yamashita, yas, baldwinlouie: Add the information...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.