Problem/Motivation

At present you can add permissions to roles on a per group basis; but you cannot remove them.

Steps to reproduce

Create group type with role permission that can't view and create a gnode type. Create a group and add these permissions to role with this module. User with role can view and create type.

Create group type with role permission that can view and create a gnode type. Create a group and add remove these permissions from the role. User with role can still view and create type.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ekes created an issue. See original summary.

lobsterr’s picture

Assigned: Unassigned » lobsterr

lobsterr’s picture

Status: Active » Needs review

I was in hurry and i didn't clean the code correctly. It should be fine now. Please check it. I will tag a new version

ekes’s picture

Assigned: lobsterr » Unassigned
Status: Needs review » Active

I don't think so. In first UI testing it's still adding.

Ah! I think I've spotted it, so I've taken the liberty to push it into the branch. Hope you don't mind.

It was checking for the SyncronizedGroupPermissionsCalculator in the group module and setting override for that one, rather than setting override for the same class name, but local namespace group_permissions one.

ekes’s picture

Status: Active » Needs review

  • LOBsTerr committed 0b0aef5 on 2.0.x
    Issue #3322496 by ekes: Permissions are only additive
    
lobsterr’s picture

Status: Needs review » Fixed

Yes, missed it too :) Thanks. Ok merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

finn lewis’s picture

Thanks for being so quick @LOBsTerr !

Is there any chance of another alpha tag release or maybe even a beta?

lobsterr’s picture

Done