Coding Standards [#3322372]

Problem/Motivation


FILE: ...pal8/web/modules/rain/modules/rain_media_bundle/rain_media_bundle.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
  1 | WARNING | "core_version_requirement" property is missing in the info.yml
    |         | file
  7 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
  8 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
  9 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 10 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 11 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 12 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 13 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 14 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 15 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 16 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
--------------------------------------------------------------------------------


FILE: ...upal8/web/modules/rain/modules/rain_media_bundle/rain_media_bundle.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /var/www/html/drupal8/web/modules/rain/rain.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 65 WARNINGS AFFECTING 64 LINES
--------------------------------------------------------------------------------
  1 | WARNING | Remove "version" from the info file, it will be added by
    |         | drupal.org packaging automatically
  1 | WARNING | "core_version_requirement" property is missing in the info.yml
    |         | file
  8 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
  9 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 10 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 11 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 12 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 13 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 14 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 15 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 16 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 17 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 18 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 19 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 20 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 21 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 22 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 23 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 24 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 25 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 26 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 27 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 28 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 29 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 30 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 31 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 32 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 33 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 34 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 35 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 36 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 37 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 38 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 39 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 40 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 41 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 42 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 43 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 44 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 45 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 46 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 47 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 48 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 49 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 50 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 51 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 52 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 53 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 54 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 55 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 56 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 57 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 58 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 59 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 60 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 61 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 62 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 63 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 64 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 65 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 66 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 67 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 68 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 69 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
 70 | WARNING | All dependencies must be prefixed with the project name, for
    |         | example "drupal:"
--------------------------------------------------------------------------------


FILE: /var/www/html/drupal8/web/modules/rain/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 8 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------
  5 | WARNING | [ ] Line exceeds 80 characters; contains 144 characters
 29 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 33 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
 34 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
 35 | WARNING | [ ] Line exceeds 80 characters; contains 147 characters
 36 | WARNING | [ ] Line exceeds 80 characters; contains 172 characters
 37 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters
 41 | WARNING | [ ] Line exceeds 80 characters; contains 155 characters
 52 | ERROR   | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: /var/www/html/drupal8/web/modules/rain/UPDATE.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES
------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 130 characters
  5 | WARNING | [ ] Line exceeds 80 characters; contains 163 characters
  9 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 13 | WARNING | [ ] Line exceeds 80 characters; contains 193 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 311 characters
 17 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters
 39 | ERROR   | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

Comment	File	Size	Author
#2	fix_coding_standard-3322372-2.patch	10.24 KB	Neeraj333

Comments

Comment #1

18 November 2022 at 07:12

Neeraj333 created an issue. See original summary.

Comment #2

Neeraj333 commented 18 November 2022 at 07:26

Assigned:	Neeraj333	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	fix_coding_standard-3322372-2.patch	10.24 KB

Comment #3

joestewart commented 23 November 2022 at 15:31

Status:

Needs review

» Needs work

Thank you for the patch. The dependencies in the rain profile have been moved to the rain_core module in https://bitbucket.org/mediacurrent/rain_core

There is a coding standard issue in the rain_demo profile's nimbus_theme.
Repository: https://bitbucket.org/mediacurrent/rain_demo
Pipelines output showing the error: https://bitbucket.org/mediacurrent/rain_demo/pipelines/results/3

FILE: ...rofiles/contrib/rain_demo/themes/nimbus_theme/nimbus_theme.theme
----------------------------------------------------------------------
FOUND 33 ERRORS AFFECTING 17 LINES
----------------------------------------------------------------------
 19 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     1
 20 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
 21 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
 23 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
 24 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
 25 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 25 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     3
 26 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 26 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
    |       |     4
 27 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     3
 28 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     2
 29 | ERROR | [x] Closing brace indented incorrectly; expected 1
    |       |     spaces, found 2
 44 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     3
 45 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     3
 46 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     5
 47 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     3
 48 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     3
 49 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 49 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
    |       |     5
 50 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
    |       |     3
----------------------------------------------------------------------
PHPCBF CAN FIX THE 33 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 185ms; Memory: 10MB