We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation.

Follow this pattern

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

CommentFileSizeAuthor
#4 Config_perms.png199.48 KBnupur badola

Issue fork config_perms-3322357

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Raghavendra A M created an issue. See original summary.

Raghavendra A M opened merge request !1

raghavendra a m’s picture

raghavendra a m commented
Status: Active » Needs review

Committed according to the proposed solution.

Please review it.

nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Config_perms.png199.48 KB

Patch is working and marking it to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-2.0 » 8.x-2.x-dev
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs review

It would be better if somebody else would review the MR.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

sourabhjain made their first commit to this issue’s fork.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!1, the file does not follow the readme.md file template instructions

1. Project page and issue is missing from the Introduction section.
2. Use - Hyphen instead of * Asterisk.
3. Supporting organization should have a different section and not mentioned in maintainer section.
4. Links should have a meaningful link text, for example:
[Drupal](https://www.drupal.org/) (i.e. not just the URL)
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!1, the issues are not yet fixed.

1. Project page and issue is missing from the Introduction section.
2. Use - Hyphen instead of * Asterisk.
3. Links should have a meaningful link text, for example:
[Drupal](https://www.drupal.org/) (i.e. not just the URL)

ravi kant made their first commit to this issue’s fork.

ravi kant’s picture

ravi kant commented
Status: Needs work » Needs review

Resolved issues.

nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR!1, the file is updated as per the readme.md file template.
Hence marking it to RTBC.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged. Thanks, everyone!

This will be in the upcoming release:

#3504197: Create Custom Permissions 8.x-2.3 release for Drupal 11 support

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Release tagged (finally!)

#3504197: Create Custom Permissions 8.x-2.3 release for Drupal 11 support