Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As I looked for this issue into the code of the book.module i realized that there are a lot of hardcoded html in it
and this is now what i want to fix.
Beside this the only(!) themeable function in book.module is theme_book_navigation() and has far too much hardcoded
I will release a patch within this day...
greets tobias
Comment | File | Size | Author |
---|---|---|---|
#5 | book.module_11.patch | 3.71 KB | Tobias Maier |
#1 | issue33220_book.module.patch | 3.72 KB | Tobias Maier |
Comments
Comment #1
Tobias Maier CreditAttribution: Tobias Maier commentedand here it is :D
I cleaned up theme_book_navigation()
now it does what it promises it makes just the book navigation
I introduced a new themeable function theme_book_export_html()
there are more unthemed html tags. but i think these are to minor to be themed...
Comment #2
moshe weitzman CreditAttribution: moshe weitzman commentedthe theme_export function looks good ... to me, it makes sense to keep breadcrumb generation out of theme function. thats semantic, not presentation.
Comment #3
Tobias Maier CreditAttribution: Tobias Maier commentedhas anyone concern about it?
I think it is not that overcomplicated patch so I set it to ready to be commited
Comment #4
Dries CreditAttribution: Dries commentedHaven't looked or reviewed this patch but clearly, it no longer applies against HEAD.
Comment #5
Tobias Maier CreditAttribution: Tobias Maier commentedCVS HEAD...
Comment #6
Dries CreditAttribution: Dries commentedCommitted to HEAD.
Comment #7
(not verified) CreditAttribution: commented