Problem/Motivation

As discovered by @quietone in #3179048-19: [meta] Remove dead code/unneeded compatibility layers now that PHP 8.1 is required:

I came across #1210798: In PHP 5.4+, html_entity_decode() doesn't decode invalid numeric entities which lead me to discover there are checks for PHP v 5.4 in core/modules/editor/tests/src/Unit/EditorXssFilter/StandardTest.php and core/tests/Drupal/Tests/Component/Utility/XssTest.php.

I haven't made an issue to remove those checks (I am focusing on something else right now) but noting it here in the hopes I come back or someone else picks this up.

This issue is created to remove these two, now _very_ obsolete checks.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3321945-2.patch2.08 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

StatusFileSize
new2.08 KB
spokje’s picture

spokje’s picture

Status: Active » Needs review
andypost’s picture

Status: Needs review » Reviewed & tested by the community

Nice clean up

  • catch committed 4b4bfcc on 10.0.x
    Issue #3321945 by Spokje: Remove PHP...
  • catch committed 15d31bc on 10.1.x
    Issue #3321945 by Spokje: Remove PHP < 5.4.0 checks
    
catch’s picture

Version: 10.1.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Fixed

Agreed these are extremely out of date, had a look that the issue this was spun out of and agree with marking that one won't fix as has already been done.

Since this is test-only dead code, committed/pushed to 10.1.x and 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.