We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation.

CommentFileSizeAuthor
#15 3321725-ReadmeMD.png120.09 KBclarkssquared
#15 3321725-After.png14.57 KBclarkssquared
#15 3321725-Before.png46.66 KBclarkssquared
#2 3321725-2.patch806 bytespanwarjatin

Issue fork cookiebot_gtm-3321725

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

panwarjatin created an issue. See original summary.

panwarjatin’s picture

panwarjatin commented
Status: Active » Needs review
StatusFileSize
new 3321725-2.patch806 bytes

Changed README.txt to README.md please review it.

Thank you.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Needs work

Please use the template provided in https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Unassigned » Sonal Gyanani

Sonal Gyanani opened merge request !1

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: Sonal Gyanani » Unassigned
Status: Needs work » Needs review

Fixed formatting issue according to Readme.md template format.
Created MR for easy preview and commenting.
Please review.
Thanks

jay jangid’s picture

jay jangid commented
Assigned: Unassigned » jay jangid
jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks @Sonal Gyanani for creating MR,
working properly and looks good for me.
So moving it to RTBC +.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: Unassigned » batigolix
Status: Reviewed & tested by the community » Needs review

I'll review this

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Needs work 
+## Configuration
+
+Configuration path `/admin/config/cookiebot_gtm`

There is much more to say about the configuration options. Please check it out and try explain what can be configured here.

There is no information about the /cookie-declaration route that is provided by this module.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: batigolix » Unassigned
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: +Novice, +Documentation

rckstr_rohan made their first commit to this issue’s fork.

rohan-sinha’s picture

rohan-sinha commented
Status: Needs work » Needs review

Added Configurations in Readme , please Review

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3321725-Before.png46.66 KB
new 3321725-After.png14.57 KB
new 3321725-ReadmeMD.png120.09 KB

Hi panwarjatin

I applied MR !1 in my local with Drupal 9.5.7 to "Cookiebot + GTM" against version 1.0.x-dev and confirmed that the Readme.txt was replaced by README.MD

Please look at the screenshot for your reference.

For your review,
Thank you.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.