Problem/Motivation

Vartheme BS5 is a base theme depends on Bootstrap 5.
Vartheme has one file for bootstrap, and there is no way to override bootstrap variables.

Proposed resolution

Add a new file called _bootstrap-variables.scss to allow override bootstrap variables.
This file will be injected in bootstrap.scss before default bootstrap variables.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1, vartheme_bs5-2.0.0-alpha3

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Comments

Abdullah Yassin created an issue. See original summary.

Abdullah Yassin’s picture

Assigned: Abdullah Yassin » rajab natshah
Status: Active » Needs review
rajab natshah’s picture

Title: Allow override bootstrap variables » Allow override Bootstrap 5 variables
rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned

Thanks to @Abdullah Yassin for the link and logic for Partials

You can create partial Sass files that contain little snippets of CSS that you can include in other Sass files. This is a great way to modularize your CSS and help keep things easier to maintain. A partial is a Sass file named with a leading underscore. You might name it something like _partial.scss. The underscore lets Sass know that the file is only a partial file and that it should not be generated into a CSS file. Sass partials are used with the @use rule.

Doing that for sure

Also thanks to RedwanJamous for #3311233: Change the way of using Bootstrap 4 variables

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes