Problem/Motivation

If you go to extend page you'll see Modal with a very minimalist description

Steps to reproduce

Proposed resolution

I think it can be improved on info.yml

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 Implement_a_better_description_for_Moda.patch547 bytesshwetaDevkate
1.png16.61 KBrenatog

Issue fork modal_page-3320904

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

RenatoG created an issue. See original summary.

shwetaDevkate’s picture

shwetaDevkate commented
StatusFileSize
new Implement_a_better_description_for_Moda.patch547 bytes

dineshreddymathuku made their first commit to this issue’s fork.

dineshreddymathuku opened merge request !28

dineshreddymathuku’s picture

dineshreddymathuku commented
Status: Active » Needs review

Manoj Raj.R made their first commit to this issue’s fork.

Manoj Raj.R opened merge request !29

Manoj Raj.R’s picture

Manoj Raj.R commented

Hi Everyone committed with 5.0x branch since MR !28 was failing.

Now MR !29 should be mergeable.

Please review it. @RenatoG

renatog’s picture

renatog commented
Status: Needs review » Needs work

Thanks a lot! Works good. I think we can update the line #1 can be only "Modal" this is because the name of project at Drupal.org and Modal_page is the machine

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review

Sure
Committed as needed.

Please review DIFF link

  • RenatoG committed 301721d on 5.0.x authored by Manoj Raj.R 
    Issue #3320904 by Manoj Raj.R, dineshreddymathuku, shwetaDevkate,...
renatog’s picture

renatog commented
Status: Needs review » Fixed

Look good. Thanks a lot

Merged to the dev branch

Thank you so much everione

renatog’s picture

renatog commented
Parent issue: » #3320910: Plan to Modal 5.0.0-beta4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.