Problem/Motivation

  • Refactor the constant variable name of OpenStackServiceInterface::*_ENDPOINT to *_SERVICE
  • Remove unnecessary $this->loadCredentials() in each method

Issue fork cloud-3320868

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !1407

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@xiaohua-guan @sekinet

Can you please review the patch? Thanks!

xiaohua guan’s picture

xiaohua guan commented

@yas

It looks good to me.

sekinet’s picture

sekinet commented
Status: Needs review » Reviewed & tested by the community

@yas

It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan @sekinet

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed a4f6068 on 5.x 
    Issue #3320868 by yas, Xiaohua Guan, sekinet: Refactor OpenStackService

  • yas committed 2882020 on 4.x 
    Issue #3320868 by yas, Xiaohua Guan, sekinet: Refactor OpenStackService
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.