Closed (fixed)
Project:
Next.js Webform
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2022 at 21:06 UTC
Updated:
30 Nov 2022 at 03:59 UTC
Jump to comment: Most recent, Most recent file
Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screen Shot 2022-11-15 at 6.50.49 PM.png | 127.34 KB | hooroomoo |
Issue fork next_webform-3320830
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
hooroomooWhile working on the EmailConfirm issue, I noticed that that label classes and styles configured for the EmailConfirm element don’t get applied to the labels of the children components (by children components I mean the WebformText for entering email and the second WebformText for confirming the email) since they each have their own wrapper/label.
I checked how it is done upstream and it is the same as how I have it in my PR, where the style and class is applied to the EmailConfirm label but the label is hidden and the labels of the children components do not inherit those props.
(In this screenshot from Drupal, I configured label styles to be blue and label class to have “test-class-label” and you can see that it does not get applied to the children labels.)
Even though it's broke in upstream because the children elements do not inherit the labels for Email Confirm, is this something we should try to have working on our end? If so, could you add a fix for that? Because I think I may run into the same issue when I start to work on refactoring CheckboxGroup to use the Checkbox component.
Comment #4
hooroomooComment #6
lauriiiI made the child labels inherit the label attributes. However, the label attributes don't seem to be configurable through the UI so it's not going to help those users.