Problem/Motivation

The variable been added in #3129534: Automatically enable the module that is providing the current database driver but now it's blocker to make any changes in system.install file

For example patch from #2552061-25: system_requirements() PDO warning overwrites other PHP messages fails https://www.drupal.org/pift-ci-job/2518122

Checking core/modules/system/system.install


FILE: /var/www/html/core/modules/system/system.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1269 | WARNING | Unused variable $pos.
----------------------------------------------------------------------

Proposed resolution

Clean it up

CommentFileSizeAuthor
#2 3320483-2.patch899 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3320483-2.patch899 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: #2552061: system_requirements() PDO warning overwrites other PHP messages » #2002650: [meta, no patch] improve maintainability by removing unused local variables
Related issues: +#2552061: system_requirements() PDO warning overwrites other PHP messages
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Yes I also noticed the same in another issue and fixed the same way.

Weird that it skipped to PHPCS checks.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Looks phpcs checking only changed files(

  • catch committed 32e2d04 on 10.0.x 
    Issue #3320483 by andypost: Remove unused variable $pos in system....
  • catch committed c5a37e6 on 10.1.x
    Issue #3320483 by andypost: Remove unused variable $pos in system....
  • catch committed ff62047 on 9.5.x
    Issue #3320483 by andypost: Remove unused variable $pos in system....
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked to 10.0x. and 9.5,x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.