Problem/Motivation

The word "Drupal" from the tooltip of insert media CKE5 button doesn't make any sense to the end user. It should be transparent to the end user whether they are using a site powered by Drupal, WP or anything else.

As per https://www.drupal.org/node/604342:

Referring to Drupal by name complicates distributions, and users may not know the site is running on Drupal

See also #2418209: Replace user facing strings that use drupal.org as example of an external url.

Steps to reproduce

N/A

Proposed resolution

Rename the tooltip from "Insert Drupal Media" to "Insert Media"

Remaining tasks

None.

User interface changes

The CKE5 insert media button will show "Insert Media" instead of "Insert Drupal Media"

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#9 3319735-9-9.x.patch80.45 KBclaudiu.cristea
#5 3319735-5.patch80.28 KBclaudiu.cristea
#5 3319735-5.interdiff.txt77.28 KBclaudiu.cristea
#3 3319735-3.patch80.25 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Assigned: claudiu.cristea » Unassigned
Status: Active » Needs review
FileSize
3319735-3.patch80.25 KB

Here we go.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. I agree that the appearance of Drupal in this context is not useful.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3319735-5.interdiff.txt77.28 KB
3319735-5.patch80.28 KB

Using the CKE5 dev tools.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: +String change, +rc target

Whoops! 🙈

Nice catch! :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed a844919d15 to 10.1.x and da28509efb to 10.0.x. Thanks!

Can we get a Drupal 9 version of this.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Patch (to be ported) » Reviewed & tested by the community
FileSize
3319735-9-9.x.patch80.45 KB

Here we go.

  • alexpott committed a844919 on 10.1.x 
    Issue #3319735 by claudiu.cristea: Rename CKE5 button tooltip "Insert...

  • alexpott committed da28509 on 10.0.x 
    Issue #3319735 by claudiu.cristea: Rename CKE5 button tooltip "Insert...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 106db336a5 to 9.5.x and c332529c26 to 9.4.x. Thanks!

  • alexpott committed 106db33 on 9.5.x 
    Issue #3319735 by claudiu.cristea: Rename CKE5 button tooltip "Insert...

  • alexpott committed c332529 on 9.4.x 
    Issue #3319735 by claudiu.cristea: Rename CKE5 button tooltip "Insert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.