Problem/Motivation

The list of funding sources for PayPal Checkout should be updated / added as of this list: https://developer.paypal.com/sdk/js/configuration/#enable-funding

Here we go:

    'paypal' => t('PayPal'),
    'card' => t('Credit or debit card'),
    'credit' => t('PayPal Credit'),
    'paylater' => t('Pay Later'),
    'bancontact' => t('Bancontact'),
    'blik' => t('BLIK'),
    'eps' => t('eps'),
    'Giropay' => t('giropay'),
    'ideal' => t('iDEAL'),
    'mercadopago' => t('Mercado Pago'),
    'mybank' => t('MyBank'),
    'p24' => t('Przelewy24'),
    'sepa' => t('SEPA-Lastschrift'),
    'sofort' => t('Sofort'),
    'venmo' => t('Venmo'),

Waiting for MR's to become alive again, perhaps I'll create a patch earlier.
For 7.x-2.x you can find the implementation here soon: #3319545: Add option to explicitly enable funding sources

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Anybody created an issue. See original summary.

anybody’s picture

Issue summary: View changes
jsacksick’s picture

MRS aren't the only way to contribute, you can provide a patch too.

anybody’s picture

Status: Active » Needs review
StatusFileSize
new1.74 KB

Here we go with the full list and a separate method to get it

jsacksick’s picture

Status: Needs review » Needs work

What about the changes to the gateway setting?

jsacksick’s picture

Also there's no commerce_paypal_funding_source_label() method? Not sure what that diff is? Is that from the 7.x version?

anybody’s picture

Also there's no commerce_paypal_funding_source_label() method?

See
https://git.drupalcode.org/project/commerce_paypal/-/blob/8.x-1.x/commer...

So what do you mean exactly?

What about the changes to the gateway setting?

You're right, I missed that, as I didn't use the 8.x version yet. I'll add that, sorry.

anybody’s picture

Status: Needs work » Needs review
StatusFileSize
new2.91 KB
jsacksick’s picture

Status: Needs review » Needs work

Again, not really sure how the patch is produced... Because there's currently no "commerce_paypal_funding_source_label()" in the 8.x version.
Also, there's probably no need to add a new procedural function... As keep in mind PayPal provides multiple gateways and not just Paypal checkout.

anybody’s picture

@jsacksick sorry but did you have a look at the link I posted?
https://git.drupalcode.org/project/commerce_paypal/-/blob/8.x-1.x/commer...

Search for commerce_paypal_funding_source_label()

Also, there's probably no need to add a new procedural function

I agree, but it wasn't me who added that procedural function.

See this commit, please: https://git.drupalcode.org/project/commerce_paypal/-/commit/ad5d3decda18...

jsacksick’s picture

Ok my bad, I thought I had the latest version locally, but was missing this last commit... sorry for this :).

anybody’s picture

Status: Needs work » Needs review

No problem, you're very welcome :)

Feel free to discuss the latest issues with the other maintainers first. I just needed some of the solutions and wanted to share it with the community.

  • jsacksick committed 1eab953 on 8.x-1.x
    Issue #3319626 by Anybody, jsacksick: Support all funding sources for...
jsacksick’s picture

Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.