Problem/Motivation

Vendor prefixes @-webkit-keyframes and @-ms-keyframes are no longer required.

Steps to reproduce

Proposed resolution

Remove them, and enable the at-rule-no-vendor-prefix rule in Stylelint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 remove-vendor-specific-prefix-patch-diff.png40.39 KBgaurav-mathur
#4 after-patch-remove-vendor-specific-prefix.png5.9 KBgaurav-mathur
#4 before-patch-remove-vendor-specific-prefix.png14.48 KBgaurav-mathur
#2 3319173-2.patch1.88 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3319173-2.patch1.88 KB
gaurav-mathur’s picture

gaurav-mathur CreditAttribution: gaurav-mathur at Dotsquares Ltd. commented
Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

gaurav-mathur CreditAttribution: gaurav-mathur at Dotsquares Ltd. commented
Assigned: gaurav-mathur » Unassigned
FileSize
before-patch-remove-vendor-specific-prefix.png14.48 KB
after-patch-remove-vendor-specific-prefix.png5.9 KB
remove-vendor-specific-prefix-patch-diff.png40.39 KB

Applied patch #2 on Drupal 10.0.x-dev
The patch worked perfectly issue got fixed
Refer to the screenshot

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

- CSS changes make sense.
- Enabling stylelint rule at-rule-no-vendor-prefix makes sense.
- Green TestBot.

RTBC for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

@gaurav-mathur Thank you for looking into this issue.

Posting screenshots of your codebase or command-line interface does not advance the issue, since the automated testing infrastructure tells us whether the change set still applies correctly.

So, I've not given issue credit for that screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Looking at the browser compatibility chart on https://developer.mozilla.org/en-US/docs/Web/CSS/@keyframes we're all good here.

Committed and pushed 63a8a2656e to 10.1.x and ba61f32af2 to 10.0.x. Thanks!

  • alexpott committed 63a8a26 on 10.1.x 
    Issue #3319173 by longwave: Remove vendor specific prefixes from...

  • alexpott committed ba61f32 on 10.0.x 
    Issue #3319173 by longwave: Remove vendor specific prefixes from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.