Problem/Motivation

  • Add the SPA form and REST API to review the OpenStack launch template in the Cloud module.
CommentFileSizeAuthor
#6 3318641-2.patch15.49 KBryo yamashita
#3 3318641.patch12.58 KBryo yamashita

Comments

Ryo Yamashita created an issue. See original summary.

ryo yamashita’s picture

Status: Needs review » Needs work
ryo yamashita’s picture

StatusFileSize
new12.58 KB
ryo yamashita’s picture

Status: Needs work » Needs review

@yas

I uploaded the patch. Please review it.

yas’s picture

Status: Needs review » Needs work

@ryo-yamashita

Thank you for adding the form. Can you please refactor the following coding standard suggestions? Thanks!

FILE: ...e_providers/openstack/src/Service/OpenStackOperationsService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 3257 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
 3270 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
----------------------------------------------------------------------
ryo yamashita’s picture

Status: Needs work » Needs review
StatusFileSize
new15.49 KB

@yas

I refactored the patch for coding standard suggestions. Thanks.

yas’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 5ac582f on 5.x
    Issue #3319061 by Ryo Yamashita, yas: Add the SPA form and REST API to...

  • yas committed 9052758 on 4.x
    Issue #3319061 by Ryo Yamashita, yas: Add the SPA form and REST API to...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.