Problem/Motivation

Create entity type OpenStack Quota

Issue fork cloud-3318898

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1397

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for adding the entity for OpenStack quota. Can you please fix the following coding standard warning?

FILE: ...ice_providers/openstack/src/Service/OpenStackBatchOperations.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1102 | WARNING | Unused variable $openstack_service.
----------------------------------------------------------------------

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

It seems that something is wrong with git server of drupal.org, because the new commit can't be reflected to the merge request. So I created a new merge request, but it can't be shown in this issue. I pasted it as below. Please take a look. Thanks.

https://git.drupalcode.org/project/cloud/-/merge_requests/1398

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. Yes, the GitLab at d.o looks out of order temporarily. The patch looks good, so I'll merge the patch to 4.x and 5.x manually, and close this issue as Fixed.

  • yas committed f2f9c1a on 4.x 
    Issue #3318898 by Xiaohua Guan, yas: Create entity type OpenStack Quota

  • yas committed 9042853 on 5.x 
    Issue #3318898 by Xiaohua Guan, yas: Create entity type OpenStack Quota
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Xiaohua Guan closed merge request !1398

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.