Default sitemap being cached for domain [#3318889]

Problem/Motivation

When viewing the sitemap it is being cached for the first domain.

Steps to reproduce

Have more than 1 domain. Once you see the sitemap for it then the second domain will also be served that sitemap instead of its own.

Proposed resolution

Minor code change in the controller to add cache context by url.site just as domain module needs it.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#2	default_sitemap_being_cached-3318889-1.patch	640 bytes	vflirt

Issue fork domain_simple_sitemap-3318889

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3318889-default-sitemap-being changes, plain diff MR !21
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

3 November 2022 at 11:54

vflirt created an issue. See original summary.

Status	File	Size
new	default_sitemap_being_cached-3318889-1.patch	640 bytes

Comment #3

tim-diels

He/Him

Dutch

Belgium 🇧🇪

commented 6 January 2023 at 07:53

Status:

Active

» Needs review

You need to set the status to needs review when providing a patch. Otherwise no one knows to review this by looking over all issues in the queue but only when opening the issue itself. Setting this to needs review.