Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 after_darcula3.png58.3 KBatul_ghate
#8 before_darcula3.png58.75 KBatul_ghate
#6 After-patch.png116.78 KBsakthivel m
#6 Before-patch.png113.25 KBsakthivel m
#6 3318872-5.patch338 bytessakthivel m
#4 After.png51.6 KBsharayurajput
#4 Before.png57.7 KBsharayurajput
#2 3318872-2.patch340 bytessakthivel m
Screenshot 2022-11-03 at 4.02.43 PM.png160.7 KBsakthivel m

Comments

Sakthivel M created an issue. See original summary.

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3318872-2.patch340 bytes

#2 Please review the patch

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

I will review this patch

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before.png57.7 KB
new After.png51.6 KB

patch is applied successfully and is working properly LGTM

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Needs work

Not sure if it's a real bug.
Reason is other themes also have a different background for active tab.
Maybe it would be better to have a better color for it.
Suggestion is to use one of the lighter grays, but removing completely is not a good idea.

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Needs review
StatusFileSize
new 3318872-5.patch338 bytes
new Before-patch.png113.25 KB
new After-patch.png116.78 KB

@Diego_Mow thank you for the suggestions.

#6 Please review the patch

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

I will review this patch.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_darcula3.png58.75 KB
new after_darcula3.png58.3 KB

Patch applied successfully, looks good to me, moving to RTBC.

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Fixed

  • Sakthivel M authored 4343f8f6 on 1.0.x 
    Issue #3318872 by Sakthivel M, sharayurajput, atul ghate, Diego_Mow:...
diego_mow’s picture

diego_mow commented
Status: Fixed » Closed (fixed)