Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 after_darcula1.png108.55 KBatul_ghate
#7 before_darcula2.png100.15 KBatul_ghate
#5 After-patch.png316.94 KBsakthivel m
#5 before-patch.png296.28 KBsakthivel m
#5 3318658-5.patch506 bytessakthivel m
#3 3318658-3-after.png140.37 KBshyam_bhatt
#3 3318658-3-before.png88.06 KBshyam_bhatt
#2 3318658-2.patch402 bytessakthivel m
Screenshot 2022-11-02 at 4.00.25 PM.png287.99 KBsakthivel m

Comments

Sakthivel M created an issue. See original summary.

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3318658-2.patch402 bytes

#2 Please review the patch

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3318658-3-before.png88.06 KB
new 3318658-3-after.png140.37 KB

I have checked the "3318658-2.patch" patch, working fine.
After the patch was applied the input text color on the vertical tab content section was visible perfectly.
Please check the below images.

Before
2022-11-04/3318658-3-before.png

After
2022-11-04/3318658-3-after.png

diego_mow’s picture

diego_mow commented
Status: Reviewed & tested by the community » Needs work

Purpose of this admin theme is to maintain "Dark Theme" available. This section is in pure white background.
Please fix this issue by changing to a proper background.

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Needs review
StatusFileSize
new 3318658-5.patch506 bytes
new before-patch.png296.28 KB
new After-patch.png316.94 KB

@Diego_Mow Thank you for the suggestions

#5 Please review the patch

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

I will review this patch.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_darcula2.png100.15 KB
new after_darcula1.png108.55 KB

Patch applied successfully, looks good to me, moving to RTBC.

diego_mow’s picture

diego_mow commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

  • Sakthivel M authored 1984c386 on 1.0.x 
    Issue #3318658 by Sakthivel M, atul ghate: Vertical tab input text color...
diego_mow’s picture

diego_mow commented
Status: Fixed » Closed (fixed)