Problem/Motivation

Following #3306446: Update Nightwatch to 2.4.1 contrib projects are resulting in 'Build Successful' if they have no nightwatch tests.

Steps to reproduce

Error handling for Nightwatch in DrupalCI is here: https://git.drupalcode.org/project/drupalci_testbot/-/blob/dev/src/Drupa...

Most likely a subtle change in nightwatch's output means this error handling is being missed.

Proposed resolution

Tweak to properly detect the error and give appropriate return code, without breaking for tests on older versions of core(and therefore older nightwatch).

Comments

hestenet created an issue. See original summary.

hestenet credited jonathan1055.

hestenet credited phenaproxima.

hestenet credited swentel.

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented
Status: Active » Needs review

This commit should fix this issue: https://git.drupalcode.org/project/drupalci_testbot/-/commit/d28ac3ca915...

Will test by running retests here: https://www.drupal.org/pift-ci-job/2511166

(Existing testbots with prior test runner code deployed need some time to cycle out).

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented
Status: Needs review » Fixed

Test against D10 dev with latest Nightwatch now comes back green! See this example: https://dispatcher.drupalci.org/job/drupal8_contrib_patches/130140/console

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented

For good measure, proved that testing on older Drupal versions (with earlier nightwatch) still works: https://dispatcher.drupalci.org/job/drupal8_contrib_patches/130141/console

And it does in fact work. Definitely fixed.

jonathan1055’s picture

jonathan1055 commented

Thanks hestenet for fixing this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.