Problem/Motivation

PHP 7.4 is EOL 28th November, and as such want to bump to 8.1, module composer.json file is locked to 5.0.x .

Having manually forced this on a local setup, the module doesnt seem to require any further code changes to be compatible with PHP8.1

Proposed resolution

Bump dependency in composer.json to allow version 6.0.x of rdkafka

Example patch attached.

CommentFileSizeAuthor
#5 kafka-php81.patch3.16 KBastoker88
kafka.patch350 bytesastoker88

Issue fork kafka-3318381

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

astoker88 created an issue. See original summary.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
Category: Support request » Task
Status: Patch (to be ported) » Needs work

This change is not compatible with D10, because the composer.json still requires "psr/log": "^1.0", but D10 core requires "psr/log": "^3.0".

We probably want to

  • change the requirement to "psr/log": "^1.0|^3.0"
  • update the description to add D10 and drop D8 which is EOL next month too
  • update the drush.services.yml to drop Drush 8 and add Drush 11 (for D10)
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Title: Bump ext-rdkafka dependency for PHP 8.1 compatibility » Bump ext-rdkafka dependency for PHP 8.1 and D10 compatibility

We may also drop rdkafka 5 support: is it actually needed with D8 support being removed ?

astoker88’s picture

astoker88 commented

all solid suggestions. let me raise a new patch with those changes.

astoker88’s picture

astoker88 commented
StatusFileSize
new kafka-php81.patch3.16 KB
astoker88’s picture

astoker88 commented
Status: Needs work » Needs review

astoker88 opened merge request !2

matio89’s picture

matio89 commented

RTBC + 1.

sreenivasparuchuri made their first commit to this issue’s fork.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Needs work

OK, so I just tried installing to check on #3391974: PHP Error on module installation and now for D10 we also need to support psr/log:^3.0 which is required by drupal/core:10.1.4

louis-cuny’s picture

louis-cuny commented

MR looks fine to me with psr/log accepting ^3.0

Is anything missing?

louis-cuny’s picture

louis-cuny commented
Status: Needs work » Needs review
fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Almost good. You can drop the extra.drush.services section from composer.json as that is no longer needed, but it doesn't hurt to keep it.

Also, you could start accepting D11 too, now that the 11.x branch actually describes what will be going in 11.x as opposed to 10.3.x : it will make upgrading easier and doesn't cost anything. But it is not *required*. As you prefer.

louis-cuny opened merge request !9

louis-cuny’s picture

louis-cuny commented

Please review latest MR

louis-cuny’s picture

louis-cuny commented

I added the missing "/11" in composer
MR is probably ready for merge I guess

louis-cuny’s picture

louis-cuny commented
Status: Needs review » Reviewed & tested by the community
louis-cuny’s picture

louis-cuny commented

Any chance to Merge this soon ?
I will have a project with kafka incoming in some time and would be happy to be able to use this module

  • fgm committed f6a02bd2 on 8.x-1.x authored by louis-cuny 
    Issue #3318381 by astoker88, louis-cuny, fgm: Bump ext-rdkafka...
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks for your participation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.