Problem/Motivation
Replace README.txt with README.md

Steps to reproduce
Need to change README.md formate

Proposed resolution
Follow this pattern
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

CommentFileSizeAuthor
#8 3318254-8.patch1.33 KBemarinho
#2 3318254.patch101 bytesanchal_gupta

Issue fork rabbit_hole-3318254

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gowthami reddy created an issue. See original summary.

anchal_gupta’s picture

anchal_gupta commented
StatusFileSize
new 3318254.patch101 bytes

I have uploaded the patch.

anchal_gupta’s picture

anchal_gupta commented
Status: Active » Needs review

gowthami reddy opened merge request !18

gowthami reddy’s picture

gowthami reddy commented

#2 patch look good to me please review it

emarinho’s picture

emarinho commented
Assigned: Unassigned » emarinho

I'll review it!!

emarinho’s picture

emarinho commented
Status: Needs review » Needs work

Found some changes for doing with the markdown file. I'll do those changes. But, about the patch #2, I also have found some changes.

emarinho’s picture

emarinho commented
Assigned: emarinho » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3318254-8.patch1.33 KB

Hey there. Couldn't apply the changes in the MR, said something like I didn't have access to push, but I had clicked 'Get push access'. Anyway, here's a patch fixing somethings that I've mentioned before. Please, kindly review it! :)

Manoj Raj.R made their first commit to this issue’s fork.

Manoj Raj.R’s picture

Manoj Raj.R commented

emarinho,
Updated in Merge request.
Please review it.

Manoj Raj.R’s picture

Manoj Raj.R commented

Found some changes for doing with the markdown file in MR18.
so compiled with proper solution in markdown format

adaucyj’s picture

adaucyj
He/Him
Primary language Portuguese, Brazil
Location Irupi, ES
commented
Assigned: Unassigned » adaucyj

I'll review it.

adaucyj’s picture

adaucyj
He/Him
Primary language Portuguese, Brazil
Location Irupi, ES
commented
Assigned: adaucyj » Unassigned
Status: Needs review » Reviewed & tested by the community

I read the file. It's following the Drupal's README template. The links are working. Didn't found any grammar error or typo.
Moving to RTBC. Great job!

emarinho’s picture

emarinho commented
Assigned: Unassigned » emarinho
Status: Reviewed & tested by the community » Needs work

Found some links without markdown template. I'll work on it.

emarinho’s picture

emarinho commented
Assigned: emarinho » Unassigned
Status: Needs work » Needs review

Added some changes. Please, kindly review it! :)

adaucyj’s picture

adaucyj
He/Him
Primary language Portuguese, Brazil
Location Irupi, ES
commented
Status: Needs review » Reviewed & tested by the community

Yes. The last changes follows the right syntax, as we can see at https://www.markdownguide.org/basic-syntax/#urls-and-email-addresses.

Matroskeen made their first commit to this issue’s fork.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Reviewed & tested by the community » Fixed

The merge request was merged to 8.x-1.x and cherry-picked to 2.0.x.
Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.