Closed (fixed)
Project:
Elasticsearch - Search API
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
28 Oct 2022 at 19:02 UTC
Updated:
15 Dec 2022 at 17:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
reenaraghavan commentedComment #4
avpadernoComment #5
avpadernoAdding an empty documentation comment just to avoid a report from a tool is useless. If the documentation comment is added, it needs to document the method and its parameters.
Comment #6
viniciuscosta commentedI'll work on it =)
Comment #7
viniciuscosta commentedI resolved almost all phpcs errors, remaining only these:
FILE: /elasticsearch_search_api/modules/elasticsearch_search_api_example/src/Search/ExampleElasticSearchParamsBuilder.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
161 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
207 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /elasticsearch_search_api/modules/elasticsearch_search_api_example/src/Search/ExampleElasticSearchResultParser.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
45 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Please, I ask kindly for someone review my patch.
Comment #8
christyanpaim commentedComment #9
christyanpaim commentedComment #10
jopdebeeck commentedComment #11
jopdebeeck commentedComment #13
jopdebeeck commentedTest run still shows 12 coding standards messages, I will fix these.
Comment #14
jopdebeeck commentedComment #15
robindh commentedPassed on some extra phpcs warnings via chat
Comment #16
jopdebeeck commentedComment #17
robindh commentedLooks good after local phpcs check
Comment #19
robindh commentedComment #20
dtfabio commentedComment #22
avpadernoComment #23
avpaderno