Problem/Motivation

Get the code up to standards

Steps to reproduce

Proposed resolution

Remaining tasks

  • Scan code of this module with phpcs, phpcbf
  • Solve issues

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

klara binon created an issue. See original summary.

reenaraghavan made their first commit to this issue’s fork.

reenaraghavan’s picture

StatusFileSize
new2.35 KB
avpaderno’s picture

Version: 1.0.0 » 1.0.x-dev
Status: Active » Needs review
avpaderno’s picture

Status: Needs review » Needs work
+  /**
+   *
+   */
   public function getResultCount(SearchResult $searchResult) {

Adding an empty documentation comment just to avoid a report from a tool is useless. If the documentation comment is added, it needs to document the method and its parameters.

viniciuscosta’s picture

Assigned: Unassigned » viniciuscosta

I'll work on it =)

viniciuscosta’s picture

Assigned: viniciuscosta » Unassigned
Status: Needs work » Needs review
StatusFileSize
new27.37 KB

I resolved almost all phpcs errors, remaining only these:

FILE: /elasticsearch_search_api/modules/elasticsearch_search_api_example/src/Search/ExampleElasticSearchParamsBuilder.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
161 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
207 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /elasticsearch_search_api/modules/elasticsearch_search_api_example/src/Search/ExampleElasticSearchResultParser.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
45 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Please, I ask kindly for someone review my patch.

christyanpaim’s picture

Assigned: Unassigned » christyanpaim
christyanpaim’s picture

Assigned: christyanpaim » Unassigned
jopdebeeck’s picture

Assigned: Unassigned » jopdebeeck
jopdebeeck’s picture

Version: 1.0.x-dev » 2.0.x-dev

jopdebeeck’s picture

Status: Needs review » Needs work

Test run still shows 12 coding standards messages, I will fix these.

jopdebeeck’s picture

Status: Needs work » Needs review
robindh’s picture

Status: Needs review » Needs work

Passed on some extra phpcs warnings via chat

jopdebeeck’s picture

Status: Needs work » Needs review
robindh’s picture

Status: Needs review » Reviewed & tested by the community

Looks good after local phpcs check

robindh’s picture

Status: Reviewed & tested by the community » Fixed
dtfabio’s picture

Assigned: jopdebeeck » dtfabio

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed
avpaderno’s picture

Status: Fixed » Closed (fixed)