Problem/Motivation

I use workspaces core module on my drupal 9 site. Also I've installed the redirect module to created redirects from old url alias to the new one in case if alias is changed.

Now I can not edit the node on non-live workspaces due to this error:

Drupal\Core\Entity\EntityStorageException: This entity can only be saved in the default workspace. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 811 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

After some investigation it turned out that issue is related to redirect entity. But actually this entity is revisionable, so it's fine to create redirects on any workspace.

Another example is related to the image field. I use crop module for image cropping and added the image field to the page node type as usual to make it possible to use media image library to insert some image to the node.

Now I'm getting the same error (This entity can only be saved/deleted in the default workspace) when I try to add an image to the node on non-live workspace. First it was related to crop entity, then it was related to the file entity (after I've disabled cropping).

But again it's totally fine to create entities of these types on non-live workspaces. Also how can I edit nodes if I can't upload/use images on non-live workspaces?

Steps to reproduce

  1. Install and enable the following modules: crop, redirect.
  2. Add the media/image field to some node type.
  3. Create some node.
  4. Switch to Stage (or any other) workspace.
  5. Try to add/change the image of that node.
  6. Or try to change path alias of that node.

The 'This entity can only be saved/deleted in the default workspace' fatal error would be displayed.

Proposed resolution

Make it possible to configure entities that could be skipped by workspaces module.
For example, I've tried to refactor the Drupal\workspaces\EntityOperations::shouldSkipPreOperations() to return TRUE to respective entity types and then everything works fine.

CommentFileSizeAuthor
#6 interdiff_5-6.txt1012 bytespooja saraah
#6 3317942-6.patch2.61 KBpooja saraah
#5 3317942-5.patch2.77 KBimmaculatexavier

Comments

i-grou created an issue. See original summary.

i-grou’s picture

i-grou commented
Title: This entity can only be deleted in the default workspace » This entity can only be created in the default workspace
Issue summary: View changes
i-grou’s picture

i-grou commented
Title: This entity can only be created in the default workspace » This entity can only be saved in the default workspace
Issue summary: View changes
i-grou’s picture

i-grou commented
Related issues: +#3025785: Cannot create entity with image in a workspace
immaculatexavier’s picture

immaculatexavier commented
Status: Active » Needs review
StatusFileSize
new 3317942-5.patch2.77 KB

Attached patch in-accordance to the proposed resolution.

pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 3317942-6.patch2.61 KB
new interdiff_5-6.txt1012 bytes

Fixed failed commands on #5
Attached interdiff patch

i-grou’s picture

i-grou commented

@immaculatexavier, @poojasaraah sorry I don't understand how this patch would fix the issue.
First, condition is always FALSE, hence it would never return on that step.
Second, there is no check neither for entity type nor for entity property (like revisionable). Does it make sense to try to create an exception that affect all entity types?
Third, does this approach really makes things configurable? How can I make it work for entities like redirect and not to work for some other entity?

amateescu’s picture

amateescu commented
Status: Needs review » Closed (duplicate)

This will be fixed by #3101671: Add mechanism to have workspaces skip processing entity types, which will allow marking entity types as "ignored" in a workspace.