Problem/Motivation

Package Current Latest
jsdom 20.0.0 20.0.2
minimist 1.2.6 1.2.7
terser 5.15.0 5.15.1
underscore 1.13.4 1.13.6

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 3317885-14-9.5.x.patch56.53 KBlongwave
#8 3317885-8.patch56.95 KBlongwave
#6 reroll_diff_2-5.txt47.95 KBAnkit.Gupta
#5 3317885-5.patch18.11 KBAnkit.Gupta
#2 3317885-2.patch56.91 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3317885-2.patch56.91 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

all good, changes to underscore are docs and CI, no changes to the actual code beside the version number.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a re-roll for yarn.lock

Ankit.Gupta’s picture

Ankit.Gupta commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3317885-5.patch18.11 KB

Reroll the patch #2 with Drupal 10.0.x

Ankit.Gupta’s picture

Ankit.Gupta commented
StatusFileSize
new reroll_diff_2-5.txt47.95 KB

Interdiff File

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

You also need to run yarn vendor-update to update the copy of underscore.min.js and core.libraries.yml.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3317885-8.patch56.95 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes

jsdom is now at 20.0.2

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

All good for me, thanks

  • catch committed 2a3188b on 10.0.x 
    Issue #3317885 by longwave, Ankit.Gupta, nod_: Update jsdom, terser,...
  • catch committed fab6469 on 10.1.x
    Issue #3317885 by longwave, Ankit.Gupta, nod_: Update jsdom, terser,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Marking fixed - however do we need an equivalent for 9.5?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 10.0.x-dev » 9.5.x-dev
Status: Fixed » Patch (to be ported)
Issue tags: +10.0.0 release notes

Yes we should do the same for 9.5.x, there is no meta for that though that I could find - maybe we need a new one. Reopening this as PTBP for updating these deps in 9.5.x as well.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 3317885-14-9.5.x.patch56.53 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

All good for me on the 9.5 branch

  • catch committed f2d51b1 on 9.5.x 
    Issue #3317885 by longwave, Ankit.Gupta, nod_, catch: Update jsdom,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -10.0.0 release notes +9.5.0 release notes

Committed/pushed to 9.5.x, thanks!

Since it's going into 9.5.x, swapping the release notes tags.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.