Problem/Motivation

We should update all dependencies to their latest versions before 9.5.0.

Steps to reproduce

Proposed resolution

composer update --with=phpunit/phpunit:^8 --with=guzzlehttp/guzzle:^6

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 Screenshot 2022-11-15 at 1.59.45 PM.png862.66 KBArti Anil Pattewar
#7 3317873-7.patch52.01 KBandypost
#7 interdiff.txt14.65 KBandypost
#4 3317873-4.patch41.13 KBlongwave
#3 3317873-3.patch39.5 KBlongwave
#2 3317873-2.patch0 byteslongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3317873-2.patch0 bytes 
$ composer-lock-diff --no-links
+---------------------------------+---------+---------+
| Production Changes              | From    | To      |
+---------------------------------+---------+---------+
| symfony/console                 | v4.4.45 | v4.4.47 |
| symfony/http-foundation         | v4.4.45 | v4.4.47 |
| symfony/http-kernel             | v4.4.45 | v4.4.47 |
| symfony/mime                    | v5.4.12 | v5.4.13 |
| symfony/psr-http-message-bridge | v2.1.2  | v2.1.3  |
| symfony/serializer              | v4.4.45 | v4.4.47 |
| symfony/translation             | v4.4.45 | v4.4.47 |
| symfony/validator               | v4.4.45 | v4.4.47 |
| symfony/var-dumper              | v5.4.11 | v5.4.14 |
+---------------------------------+---------+---------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/ca-bundle                 | 1.3.3   | 1.3.4   |
| drupal/coder                       | 8.3.15  | 8.3.16  |
| phpstan/phpdoc-parser              | 1.6.4   | 1.13.0  |
| phpunit/phpunit                    | 8.5.29  | 8.5.30  |
| sebastian/comparator               | 3.0.3   | 3.0.5   |
| sebastian/exporter                 | 3.1.4   | 3.1.5   |
| seld/phar-utils                    | 1.2.0   | 1.2.1   |
| sirbrillig/phpcs-variable-analysis | v2.11.4 | v2.11.9 |
| slevomat/coding-standard           | 7.2.1   | 8.6.2   |
| symfony/lock                       | v4.4.40 | v4.4.46 |
| symfony/phpunit-bridge             | v5.4.11 | v5.4.14 |
+------------------------------------+---------+---------+
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3317873-3.patch39.5 KB

0 byte patch, oops.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3317873-4.patch41.13 KB

Some more patch level updates.

+---------------------------------+---------+---------+
| Production Changes              | From    | To      |
+---------------------------------+---------+---------+
| symfony/console                 | v4.4.45 | v4.4.48 |
| symfony/http-foundation         | v4.4.45 | v4.4.48 |
| symfony/http-kernel             | v4.4.45 | v4.4.48 |
| symfony/mime                    | v5.4.12 | v5.4.13 |
| symfony/psr-http-message-bridge | v2.1.2  | v2.1.3  |
| symfony/serializer              | v4.4.45 | v4.4.47 |
| symfony/translation             | v4.4.45 | v4.4.47 |
| symfony/validator               | v4.4.45 | v4.4.48 |
| symfony/var-dumper              | v5.4.11 | v5.4.14 |
+---------------------------------+---------+---------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/ca-bundle                 | 1.3.3   | 1.3.4   |
| drupal/coder                       | 8.3.15  | 8.3.16  |
| instaclick/php-webdriver           | 1.4.15  | 1.4.16  |
| phpstan/phpdoc-parser              | 1.6.4   | 1.13.0  |
| phpunit/phpunit                    | 8.5.29  | 8.5.31  |
| sebastian/comparator               | 3.0.3   | 3.0.5   |
| sebastian/exporter                 | 3.1.4   | 3.1.5   |
| seld/phar-utils                    | 1.2.0   | 1.2.1   |
| sirbrillig/phpcs-variable-analysis | v2.11.4 | v2.11.9 |
| slevomat/coding-standard           | 7.2.1   | 8.6.2   |
| symfony/lock                       | v4.4.40 | v4.4.46 |
| symfony/phpunit-bridge             | v5.4.11 | v5.4.14 |
+------------------------------------+---------+---------+
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Bump, this could do with review/commit before 9.5.0-rc1.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think it needs bump for phpstan too

phpstan/phpstan 1.9.1 1.9.2

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt14.65 KB
new 3317873-7.patch52.01 KB

Using COMPOSER_ROOT_VERSION=9.5.x-dev c2 update --with=phpunit/phpunit:^8 --with=guzzlehttp/guzzle:^6 -W

and "slevomat/coding-standard": "8.6.4" instead of 8.6.2

$ ~/.composer/vendor/bin/composer-lock-diff --no-links
+----------------------------------+---------+---------+
| Production Changes               | From    | To      |
+----------------------------------+---------+---------+
| symfony/console                  | v4.4.45 | v4.4.48 |
| symfony/http-foundation          | v4.4.45 | v4.4.48 |
| symfony/http-kernel              | v4.4.45 | v4.4.48 |
| symfony/mime                     | v5.4.12 | v5.4.13 |
| symfony/polyfill-ctype           | v1.26.0 | v1.27.0 |
| symfony/polyfill-iconv           | v1.26.0 | v1.27.0 |
| symfony/polyfill-intl-idn        | v1.26.0 | v1.27.0 |
| symfony/polyfill-intl-normalizer | v1.26.0 | v1.27.0 |
| symfony/polyfill-mbstring        | v1.26.0 | v1.27.0 |
| symfony/polyfill-php80           | v1.26.0 | v1.27.0 |
| symfony/psr-http-message-bridge  | v2.1.2  | v2.1.3  |
| symfony/serializer               | v4.4.45 | v4.4.47 |
| symfony/translation              | v4.4.45 | v4.4.47 |
| symfony/validator                | v4.4.45 | v4.4.48 |
| symfony/var-dumper               | v5.4.11 | v5.4.14 |
+----------------------------------+---------+---------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/ca-bundle                 | 1.3.3   | 1.3.4   |
| drupal/coder                       | 8.3.15  | 8.3.16  |
| instaclick/php-webdriver           | 1.4.15  | 1.4.16  |
| phpstan/phpdoc-parser              | 1.6.4   | 1.13.0  |
| phpunit/phpunit                    | 8.5.29  | 8.5.31  |
| sebastian/comparator               | 3.0.3   | 3.0.5   |
| sebastian/exporter                 | 3.1.4   | 3.1.5   |
| seld/phar-utils                    | 1.2.0   | 1.2.1   |
| sirbrillig/phpcs-variable-analysis | v2.11.4 | v2.11.9 |
| slevomat/coding-standard           | 7.2.1   | 8.6.4   |
| symfony/lock                       | v4.4.40 | v4.4.46 |
| symfony/phpunit-bridge             | v5.4.11 | v5.4.14 |
+------------------------------------+---------+---------+
Arti Anil Pattewar’s picture

Arti Anil Pattewar commented
StatusFileSize
new Screenshot 2022-11-15 at 1.59.45 PM.png862.66 KB

Failed to apply patch #7 on D9.5.x. Attaching screenshot for reference.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

- Patch #7 applies cleanly both on TestBot (https://dispatcher.drupalci.org/job/drupal_patches/154867/) and locally.
- When applied locally the composer-lock-diff --no-links output is identical to the outpout in #7.

RTBC for me.

  • catch committed b5bd838 on 9.5.x 
    Issue #3317873 by longwave, andypost, Spokje: Update dependencies for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed b5bd838 and pushed to 9.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

effulgentsia’s picture

effulgentsia commented
Title: Update dependencies for Drupal 9.5 » Update PHP dependencies for Drupal 9.5
Status: Closed (fixed) » Postponed
Issue tags: +Drupal 9.5.0 release blocker

As of today, composer update --with=phpunit/phpunit:^8 --with=guzzlehttp/guzzle:^6 does nothing on Drupal 9.5.x, yay!

We'll want to check this again just prior to releasing 9.5.0, so tagging as a release blocker, and postponing it until there's either something to update or it's time to release 9.5.0.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Postponed » Fixed

We should have separate issues for separate commits. Looks like there are no further updates anyway. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.