Problem/Motivation

FILE: ...les/contrib/stop_admin/tests/src/Functional/StopAdminUserLoginPageTest.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
 30 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 31 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 32 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 33 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...es/contrib/stop_admin/tests/src/Functional/StopAdminUserLoginBlockTest.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
 109 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 110 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
 123 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
 124 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 213ms; Memory: 10MB
CommentFileSizeAuthor
#12 Screenshot from 2022-10-28 09-33-51.png23.34 KBerikaagp
#5 Screenshot from 2022-10-27 12-38-13.png32.33 KBerikaagp
#2 coding-standard-3317612-2.patch1.48 KBrohit rana

Issue fork stop_admin-3317612

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rohit Rana created an issue. See original summary.

rohit rana’s picture

rohit rana commented
StatusFileSize
new coding-standard-3317612-2.patch1.48 KB
rohit rana’s picture

rohit rana commented
Assigned: rohit rana » Unassigned
Status: Active » Needs review
erikaagp’s picture

erikaagp commented
Assigned: Unassigned » erikaagp

I'll review it

erikaagp’s picture

erikaagp commented
Assigned: erikaagp » Unassigned
StatusFileSize
new Screenshot from 2022-10-27 12-38-13.png32.33 KB

Hi, patch applied succesfully, I found a silly phpcs error (screenshot), I fixed it, and pushed the changes with a commit on the branch. Needs review of the last changes

erikaagp opened merge request !4

suraj2012’s picture

suraj2012 commented
Status: Needs review » Reviewed & tested by the community

Validated merge request !4. Patch getting applied. Changing status to Reviewed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-1.4 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

The report is for 11 different lines, but the patch just changes three lines.

rohit rana’s picture

rohit rana commented

I have made changes to 3 lines which resolve all 11 PHPCS errors.

erikaagp’s picture

erikaagp commented

That's true @Rohit Rana made changes to 3 lines which resolve all 11 PHPCS errors, and I made a remaining phpcs change. Suraj2012 validated it.

erikaagp’s picture

erikaagp commented
Assigned: Unassigned » erikaagp

I'll work on it again

erikaagp’s picture

erikaagp commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2022-10-28 09-33-51.png23.34 KB

Hi @apaderno ! :) I checked the issue again, there isn't any phpcs issue on it, @Rohit Rana and I solved it. So I'll move it again to "Needs review" to be tested by another person. Here you have a second screenshot which proves what I see. Could you please send us an screenshot of what you say it's wrong? In order to work on it and solve it. Thank you.

erikaagp’s picture

erikaagp commented
Assigned: erikaagp » Unassigned
juancec’s picture

juancec commented
Status: Needs review » Reviewed & tested by the community

Hi, all the PHPCS issues have been fixed. I ran the command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,yaml,feature,js,json,ts,tsx,feature,twig
Moving the issue to RTBC.

  • 052dd71 committed on 8.x-1.x 
    Issue #3317612 by erikaagp, Rohit Rana: Fix what reported by phpcs
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Giving everyone a credit for their work ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.