Problem/Motivation

Wrong and restricted width in embed responsive in Varbase video player for YouTube and Vimeo embedded Video Slides
After - Fix Ultrawide embed responsive varbase video player for Youtube and Vimeo embedded Slides

Proposed resolution

Fixed and released in Varbase Media Hero Slider 9.0.6
#3317239: Fix Ultrawide screens with embed responsive in Varbase video player for YouTube and Vimeo embedded Video Slides
Have Ultrawide support included Vartheme BS4 and in the template Vartheme Sub-theme template.
Which has the following in the "vartheme_bs4.info.yml" file

  # Heroslider: Uncomment the following to use varbase heroslider styling.
  #  varbase_heroslider_media/general-styling: vartheme_bs4/heroslider

Add the following in the "VARTHEME_BS4_SUBTHEME.starterkit.yml" file

  # Heroslider: Uncomment the following to disable the vartheme_bs4/heroslider
  #             Library if it was enabled in vartheme_bs4 heroslider styling.
  # vartheme_bs4/heroslider: false

and

  # VARTHEME_BS4_SUBTHEME Varbase Media Hero Slider style.
  - VARTHEME_BS4_SUBTHEME/heroslider

Before - Fix Ultrawide embed responsive varbase video player for Youtube and Vimeo embedded Slides

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, vartheme_bs4-9.0.19

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3317532: Fixed Ultrawide screens with embed responsive in Varbase video player for YouTube and Vimeo embedded Video Slides in Vartheme BS4 and in the Vartheme Sub-theme template
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Title: Fix Ultrawide screens with embed responsive in Varbase video player for YouTube and Vimeo embedded Video Slides in Vartheme BS4 » Fix Ultrawide screens with embed responsive in Varbase video player for YouTube and Vimeo embedded Video Slides in Vartheme BS4 and in the Vartheme Sub-theme template

  • Rajab Natshah committed d1197f1 on 9.0.x
    Issue #3317532: Fix Ultrawide screens with embed responsive in Varbase...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-9.0.0, +vartheme_bs4-9.0.19
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released vartheme_bs4-9.0.19

dineshreddymathuku’s picture

Hi @Rajab Natshah i hope your #5patch is working right bcz thats looks good for me

rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.